Skip to content

Add Google Artifact Registry and custom-id #2030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2024
Merged

Add Google Artifact Registry and custom-id #2030

merged 2 commits into from
Feb 23, 2024

Conversation

@FourSigma
Copy link
Contributor

@FourSigma FourSigma commented Feb 22, 2024 •
edited
Loading

  • Add Google Artifact Registry to replicated registry add command

    • Google Artifact Registry supports both service account and OAuth token based authentication

  • Updated docs for creating new customers with --custom-id my-salesforce-id parameter

    • Updates replicated customer ls to display new CUSTOM_ID column

@FourSigma FourSigma requested a review from a team as a code owner February 22, 2024 22:38
@replicated-ci replicated-ci added type::docs Improvements or additions to documentation type::feature labels Feb 22, 2024
@netlify
Copy link

netlify bot commented Feb 22, 2024 •
edited
Loading

✅ Deploy Preview for replicated-docs-upgrade ready!

Name Link
🔨 Latest commit f400915
🔍 Latest deploy log https://app.netlify.com/sites/replicated-docs-upgrade/deploys/65d7ccfc0a5fff00082ec9bb
😎 Deploy Preview https://deploy-preview-2030--replicated-docs-upgrade.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Feb 22, 2024 •
edited
Loading

✅ Deploy Preview for replicated-docs ready!

Name Link
🔨 Latest commit f400915
🔍 Latest deploy log https://app.netlify.com/sites/replicated-docs/deploys/65d7ccfc0a5fff00082ec9b9
😎 Deploy Preview https://deploy-preview-2030--replicated-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AmberAlston
Copy link
Member

AmberAlston commented Feb 22, 2024

PR looks good but we do need a release note still for both of these CLI updates

@FourSigma
Copy link
Contributor Author

FourSigma commented Feb 23, 2024

PR looks good but we do need a release note still for both of these CLI updates

Thanks @paigecalvert. Are these release notes in the Replicated CLI repo not sufficient? https://github.com/replicatedhq/replicated/releases/tag/v0.68.0?

@paigecalvert
Copy link
Contributor

paigecalvert commented Feb 23, 2024

PR looks good but we do need a release note still for both of these CLI updates

Thanks @paigecalvert. Are these release notes in the Replicated CLI repo not sufficient? https://github.com/replicatedhq/replicated/releases/tag/v0.68.0?

I think @AmberAlston left that comment, @FourSigma 🙂 . And I reckon she's just referring to adding the release note for them to the Replicated docs as well

@FourSigma
Copy link
Contributor Author

FourSigma commented Feb 23, 2024

PR looks good but we do need a release note still for both of these CLI updates

Thanks @paigecalvert. Are these release notes in the Replicated CLI repo not sufficient? https://github.com/replicatedhq/replicated/releases/tag/v0.68.0?

I think @AmberAlston left that comment, @FourSigma 🙂 . And I reckon she's just referring to adding the release note for them to the Replicated docs as well

Slaps forehead. Thanks @paigecalvert. One thing I noticed about the Vendor Portal release notes is that we do not log Replicated CLI changes. Additionally, the backend API changes were already logged in the VP release docs (see Feb 9th and Feb. 14th).

@AmberAlston AmberAlston self-requested a review February 23, 2024 15:50
@AmberAlston
Copy link
Member

AmberAlston commented Feb 23, 2024

I'm good with this as-is. See RN discussion over in this comment - https://app.shortcut.com/replicated/story/98503/cli-can-set-a-custom-id-when-creating-customer#activity-99849

@paigecalvert do you want to look at this before I merge it?

@AmberAlston
Copy link
Member

AmberAlston commented Feb 23, 2024

@paigecalvert Actually, I forgot you were out today. I'll just push it live.

@AmberAlston AmberAlston merged commit 6ea58dc into main Feb 23, 2024
@AmberAlston AmberAlston deleted the sm-add-gar-and-custom-id branch February 23, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AmberAlston AmberAlston AmberAlston approved these changes

@paigecalvert paigecalvert Awaiting requested review from paigecalvert

Assignees

No one assigned

Labels

type::docs Improvements or additions to documentation type::feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@FourSigma @AmberAlston @paigecalvert @replicated-ci